This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Final clean-up of node naming and order#332
Merged
bettinaheim merged 11 commits intobeheim/transformationNodesfrom Feb 24, 2020
Merged
Final clean-up of node naming and order#332bettinaheim merged 11 commits intobeheim/transformationNodesfrom
bettinaheim merged 11 commits intobeheim/transformationNodesfrom
Conversation
added 10 commits
February 23, 2020 20:01
ScottCarda-MS
approved these changes
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing all the "Before" handles for now, and making the "Dispatch" handles just regular virtual "On" handles.
Ultimately we may want to add a Before and an After handle for each of the On nodes, where the On node would invoke both of those handles. For now, I have refrained from doing to - we will see if that is indeed needed and it can always be added.