This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Changes to BuiltIn Records#368
Merged
ScottCarda-MS merged 5 commits intosccarda/GeneralLiftingfrom Mar 13, 2020
Merged
Conversation
ScottCarda-MS
requested review from
alan-geller,
bamarsha,
bettinaheim and
cesarzc
alan-geller
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsSelfAdjoint is a field of the InferredCallableInformation object, which we need to fill out when we generate calls to these built-in objects. The IsSelfAdjoint can't be determined from the signature, so we need to provide it explicitly, in the case of operations.
I need a review on the structural changes to the BuiltIn record, before I go and change the references.