This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Sccarda/intrinsic fix monomorphization #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
reviewed
Apr 29, 2020
| public readonly ImmutableHashSet<QsQualifiedName> ExemptCallableSet; | ||
|
|
||
| public TransformationState(ImmutableDictionary<NonNullable<string>, IEnumerable<QsCallable>> namespaceCallables) | ||
| public TransformationState(ILookup<NonNullable<string>, QsCallable> namespaceCallables, ImmutableHashSet<QsQualifiedName> exemptCallableSet) |
Contributor
There was a problem hiding this comment.
I like the use of the lookup!
bettinaheim
reviewed
Apr 29, 2020
bettinaheim
reviewed
Apr 29, 2020
| namespace Microsoft.Quantum.QsCompiler.Transformations.Monomorphization.Validation | ||
| { | ||
| public class ValidateMonomorphization : SyntaxTreeTransformation<ValidateMonomorphization.TransformationState> | ||
| { |
Contributor
There was a problem hiding this comment.
Looks like the validation is also complete! Great!
bettinaheim
approved these changes
Apr 29, 2020
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
Thanks for adding this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent Intrinsic and certain Built In callables from being monomorphized or removed from the tree.