Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@bettinaheim
Copy link
Contributor

@bettinaheim bettinaheim commented May 4, 2020

No description provided.

swernli
swernli previously approved these changes May 4, 2020
Copy link
Contributor

@ScottCarda-MS ScottCarda-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't having the generic Length in the syntax tree cause issues?

Edit: Length is intrinsic, so it being generic is fine.

@swernli swernli self-requested a review May 4, 2020 22:02
@swernli swernli dismissed their stale review May 4, 2020 22:03

Resetting my review response until we resolve the question of explicit exemption for Length.

Copy link
Contributor

@ScottCarda-MS ScottCarda-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing this. Please remember to check for and remove trailing spaces before merging in.

@bettinaheim bettinaheim merged commit 24fd520 into master May 28, 2020
@bettinaheim bettinaheim deleted the beheim/bugFixes branch May 28, 2020 07:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants