This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Prevent entry point driver from being loaded as a QSC reference #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarzc
reviewed
May 13, 2020
cesarzc
approved these changes
May 13, 2020
Contributor
cesarzc
left a comment
cesarzc
left a comment
There was a problem hiding this comment.
Looks good.
Regarding the TODO, if there is not an issue already tracking it, can you please create one and add the issue number in the comment?
bettinaheim
approved these changes
May 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a problem caused by including the entry point driver assembly in the C# generation package. The SDK tries to load all of the assemblies, but this one has dependencies that are not included in the package, so loading fails.
Note: This is to feature/azure-quantum-preview instead of features/azure-quantum-preview to match the branch name on qsharp-runtime.