This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Adjusting ExecutionTaret for partial matching #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
reviewed
May 27, 2020
| <ResolvedQsharpExecutionTarget Condition="('$(ResolvedQsharpOutputType)' == 'QsharpExe' Or '$(NoEntryPoint)' == 'true') And '$(ExecutionTarget)' == 'ionq.qpu'">IonQProcessor</ResolvedQsharpExecutionTarget> | ||
| <ResolvedQsharpExecutionTarget Condition="('$(ResolvedQsharpOutputType)' == 'QsharpExe' Or '$(NoEntryPoint)' == 'true') And '$(ExecutionTarget)' == 'ionq.simulator'">IonQProcessor</ResolvedQsharpExecutionTarget> | ||
| <ResolvedQsharpExecutionTarget Condition="('$(ResolvedQsharpOutputType)' == 'QsharpExe' Or '$(NoEntryPoint)' == 'true') And '$(ExecutionTarget)' == 'qci'">QCIProcessor</ResolvedQsharpExecutionTarget> | ||
| <ResolvedQsharpExecutionTarget Condition="('$(ResolvedQsharpOutputType)' == 'QsharpExe' Or '$(NoEntryPoint)' == 'true') And $(ExecutionTarget.StartsWith('honeywell.'))">HoneywellProcessor</ResolvedQsharpExecutionTarget> |
Contributor
There was a problem hiding this comment.
Now I am getting nitpicky: it would be nice if capitalization didn't matter.
Contributor
Author
There was a problem hiding this comment.
Let me see if I can make that adjustment...
Contributor
Author
There was a problem hiding this comment.
Unfortunately it looks like there isn't support for case insensitive comparisons here, so we'll need to stay picky.
bettinaheim
approved these changes
May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from @anpaz-msft, adjusting the ExecutionTarget to support partial matching.