This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Some tools for adding attributes #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
requested review from
IrinaYatsenko,
ScottCarda-MS,
bamarsha and
cgranade
added 2 commits
June 15, 2020 06:59
cgranade
reviewed
Jun 15, 2020
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
I didn't go through the testing section in as much detail, but this looks good to me; I just had a few minor C# suggestions, but that's about it. Thanks!
Co-authored-by: Chris Granade <chgranad@microsoft.com>
…rp-compiler into beheim/docsToTest
9 tasks
cgranade
reviewed
Jun 17, 2020
ScottCarda-MS
approved these changes
Jun 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into a random project on the weekend and ended up writing some tools to add attributes to callables in a compilation. Seems like something handy to take in.