This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fixing escape handling in string parsing #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
commented
Jun 19, 2020
swernli
changed the title
This change adds proper escape character handling for literal strings. Fixes Escape sequences in string literals are not interpreted #458
swernli
force-pushed
the
swernli/escape-fix
branch
from
1e91e79 to
0798136
Compare
swernli
force-pushed
the
swernli/escape-fix
branch
from
7e2b1e5 to
d7f3b04
Compare
bettinaheim
reviewed
Jun 20, 2020
bettinaheim
approved these changes
Jun 20, 2020
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
Great to have this fixed!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds proper escape character handling for literal strings.
Fixes Escape sequences in string literals are not interpreted #458