-
Notifications
You must be signed in to change notification settings - Fork 173
Remove version and copyright properties from Q# grammar file #509
Conversation
|
I think I might've been the first person to put that field in this file, and that was back in 2017... One thing that might break (I can't find a paper trail for this so it's from memory) is that VS is really good at caching the grammars (in |
JakuJ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be an issue with the "copyright" field as well.
Co-authored-by: Jakub Janaszkiewicz <janaszkiewicz.jakub@gmail.com>
I tried this out:
It worked for me without a |
tcNickolas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope that means that VS team changed the caching behavior since 2017 when I last looked into it :-)
That was my only concern, so looks good!
The
.v.templatefile extension for the Q# grammar file means that GitHub Linguist did not recognize it, which means that syntax highlighting for Q# cannot be added to GitHub (see issue #504 from @JakuJ). I'm removing the#SEMVER_VERSION#template variable from the grammar file so the template extension can be removed. Here are my reasons for removing it:versionproperty.versionproperty.versionproperty is not actually part of thetmlanguage.jsonschema that the file uses.Since I don't know what the original reason was for including the version number, I'm not sure if this will break something that I haven't thought of. @bettinaheim @ricardo-espinoza?
Closes #504.