This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Type Parameter Combine #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarda-MS
commented
Jul 14, 2020
…. Removed old code.
…thm in unit tests.
cesarzc
reviewed
Jul 16, 2020
cesarzc
reviewed
Jul 16, 2020
cesarzc
reviewed
Jul 16, 2020
cesarzc
reviewed
Jul 16, 2020
cesarzc
reviewed
Jul 16, 2020
cesarzc
reviewed
Jul 16, 2020
cesarzc
reviewed
Jul 16, 2020
Contributor
Author
|
Unfortunately this PR just became a bit more difficult to review as I've had to add in changes to align unrelated parts of the call graph walker to the new style rules. Sorry about that! |
Co-authored-by: César Zaragoza Cortés <cesar.zaragoza@outlook.com>
cesarzc
reviewed
Jul 16, 2020
cesarzc
suggested changes
Jul 16, 2020
Contributor
cesarzc
left a comment
cesarzc
left a comment
There was a problem hiding this comment.
Looks good, I left a few comments with no major concerns.
It would be great if another person could also take a look at this change because I am not an expert in this area and I might be missing something.
…ady added resolutions with the current resolution.
bamarsha
reviewed
Jul 16, 2020
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Contributor
Author
|
I've created a separate PR for the style changes: #525. Once that PR is complete, the diff here will no longer contain the style changes and will be more streamline to the purpose of the PR. |
cesarzc
approved these changes
Jul 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the algorithm for combining type parameter resolution dictionaries. Added support for combining nested types.