Do not include dependencies with PrivateAssets="All" in the compiler package

[bamarsha]

FindNuspecReferences.ps1 adds all dependencies to Compiler.nuspec, even ones marked with PrivateAssets="All". That meant that the StyleCop analyzers for the Q# compiler source code were propagating to projects that have a reference to the Q# compiler package, which is a bit unwelcome for downstream projects.

[ScottCarda-MS]

This seems like the right thing to prevent private assets from propagating to other repoes, but I don't know what all the possible implications of making this change will be. Are there any dependencies with PrivateAssets="All" that are supposed to be propagated? Is there an easy way to tell?

[bamarsha]

It seems that PrivateAssets="All" implies that something is a development-only (i.e. build-time only) reference, and shouldn't be a package dependency:

• https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets

• PackageReference should support DevelopmentDependency metadata NuGet/Home#4125 (comment) referring to dotnet pack:

  pack should not emit a dependency when <PrivateAssets>all</PrivateAssets> is specified

[filipw]

I just ran into this today. Thanks for fixing this, currently the compiler nuget package drags in Stylecop reference when installed and ruins the project's code analysis 😂 it would be good to release the new version out

[bamarsha]

Yes, sorry about that! I believe you can work around it for now by adding this .editorconfig to your project, which should disable all StyleCop rules...