This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Replace LSP positions with Q# positions #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces LSP position types with Q# position types in the compilation manager. Removed several functions that operated on LSP positions that are no longer necessary because the functionality is built into the Q# position type.
Because LSP ranges haven't been replaced yet, a lot of conversions like
range.Start.ToQSharp()andrange.End.ToQSharp()needed to be added temporarily. Those should go away when LSP ranges are replaced with Q# ranges that use Q# positions for their start and end points. (Probably in the next PR.)Part of #506.