Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@amrondonp
Copy link

  • Added 'space after if' rule
  • Added unit test for it
  • Simple rearrangement of files, created rules folder, separate the formatter implementation from the format file that imports vscode for testing propouses

@ghost
Copy link

ghost commented Jul 27, 2020

CLA assistant check
All CLA requirements met.

Copy link

@theRoughCode theRoughCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a quick feedback regarding the structure. I'm leaning more towards having each file under the rules/ folder each expose an array of rules that are a group of similar rules. For example, rules/operation.ts would expose a set of rules that are related to operations. This imo would make the code within format-document.ts cleaner as the number of rules grow.

Copy link

@theRoughCode theRoughCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

@theRoughCode theRoughCode merged commit 548450e into microsoft:raphael/vsc-formatter Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants