This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 173
Integrate space after if, with tests to formatter branch #536
Merged
theRoughCode
merged 14 commits into
microsoft:raphael/vsc-formatter
from
amrondonp:anrondon/vsc-formatter-rules
Jul 27, 2020
Merged
Integrate space after if, with tests to formatter branch #536
theRoughCode
merged 14 commits into
microsoft:raphael/vsc-formatter
from
amrondonp:anrondon/vsc-formatter-rules
Jul 27, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrondonp
commented
Jul 27, 2020
- Added 'space after if' rule
- Added unit test for it
- Simple rearrangement of files, created rules folder, separate the formatter implementation from the format file that imports vscode for testing propouses
theRoughCode
suggested changes
Jul 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a quick feedback regarding the structure. I'm leaning more towards having each file under the rules/ folder each expose an array of rules that are a group of similar rules. For example, rules/operation.ts would expose a set of rules that are related to operations. This imo would make the code within format-document.ts cleaner as the number of rules grow.
Co-authored-by: Raphael Koh <raph.koh@gmail.com>
theRoughCode
approved these changes
Jul 27, 2020
theRoughCode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.