This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Minor fixes and match functions in args formatting rule #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
reviewed
Jul 28, 2020
amrondonp
reviewed
Jul 28, 2020
amrondonp
approved these changes
Jul 28, 2020
Contributor
|
Given that the formatter doesn't yet support multiple lines, I think some of the declaration matching rules will get confused by declarations that span multiple lines. If the mocha test infra supports it, it would be good to add a skipped test that is known to fail on multi-line callable declaration so that known case is captured. |
swernli
approved these changes
Jul 28, 2020
Author
|
My next PR will focus on multiline support! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes/improves stuff from #535 and adds functions tot the args formatting rule.