This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fixing pack script #545
Merged
Fixing pack script #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing bug in pack script that kept failures in VS and VSCode extension packing from being correctly caught.
Contributor
Author
|
@amrondonp FYI |
ricardo-espinoza
approved these changes
Jul 29, 2020
Contributor
|
Let's notice that this PR will remain blocked by the checks until we clean the pre-exiting build issues in the VS Code extension that are exposed by taking this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug in pack script that kept failures in VS and VSCode extension packing from being correctly caught.