Master into call graph walker

build/build.ps1

@@ -51,7 +51,7 @@ function Build-VSCode() {
             }
         } Catch {
             Write-Host "##vso[task.logissue type=error;]Failed to build VS Code extension."
-            $all_ok = $False
+            $script:all_ok = $False
         }
     } else {
         Write-Host "##vso[task.logissue type=warning;]npm not installed. Will skip creation of VS Code extension"
@@ -92,7 +92,7 @@ function Build-VS() {
                     }
                 } Catch {
                     Write-Host "##vso[task.logissue type=error;]Failed to build VS extension."
-                    $all_ok = $False
+                    $script:all_ok = $False
                 }
             } else {
                 Write-Host "msbuild not installed. Will skip building the VisualStudio extension"

build/pack.ps1

@@ -168,7 +168,7 @@ function Pack-VSCode() {
             }
         } Catch {
             Write-Host "##vso[task.logissue type=error;]Failed to pack VS Code extension."
-            $all_ok = $False
+            $Script:all_ok = $False
         }
     } else {
         Write-Host "##vso[task.logissue type=warning;]vsce not installed. Will skip creation of VS Code extension package"
@@ -195,7 +195,7 @@ function Pack-VS() {
             }
         } Catch {
             Write-Host "##vso[task.logissue type=error;]Failed to pack VS extension."
-            $all_ok = $False
+            $Script:all_ok = $False
         }
     } else {    
         Write-Host "msbuild not installed. Will skip creation of VisualStudio extension package"

omnisharp.json

@@ -3,6 +3,7 @@
         "enableEditorConfigSupport": true
     },
     "RoslynExtensionsOptions": {
-        "enableAnalyzersSupport": true
+        "enableAnalyzersSupport": true,
+        "enableDecompilationSupport": true
     }
 }

src/QsCompiler/CommandLineTool/CompilationTracker.cs

@@ -5,8 +5,9 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
+using System.Linq;
+using System.Text.Json;
 using System.Threading;
-using Newtonsoft.Json;
 
 namespace Microsoft.Quantum.QsCompiler.CommandLineCompiler
 {
@@ -105,6 +106,21 @@ public CompilationTaskNode(CompilationTask task)
                 this.Task = task;
                 this.Children = new Dictionary<string, CompilationTaskNode>();
             }
+
+            public void WriteToJson(Utf8JsonWriter jsonWriter, string prefix)
+            {
+                var preparedPrefix = "";
+                if (!string.IsNullOrEmpty(prefix)) {
+                    preparedPrefix = $"{prefix}.";
+                }
+
+                var propertyName = $"{preparedPrefix}{this.Task.Name}";
+                jsonWriter.WriteNumber(propertyName, this.Task.DurationInMs ?? -1);
+                foreach (var entry in this.Children.OrderBy(e => e.Key))
+                {
+                    entry.Value.WriteToJson(jsonWriter, propertyName);
+                }
+            }
         }
 
         /// <summary>
@@ -294,24 +310,27 @@ public static void PublishResults(string outputFolder)
             Directory.CreateDirectory(outputPath);
             using (var file = File.CreateText(Path.Combine(outputPath, CompilationPerfDataFileName)))
             {
-                var serializer = new JsonSerializer
+                var jsonWriterOptions = new JsonWriterOptions()
                 {
-                    Formatting = Formatting.Indented
+                    Indented = true
                 };
 
-                serializer.Serialize(file, compilationProcessesForest);
+                var jsonWriter = new Utf8JsonWriter(file.BaseStream, jsonWriterOptions);
+                jsonWriter.WriteStartObject();
+                foreach (var tree in compilationProcessesForest.OrderBy(t => t.Task.Name))
+                {
+                    tree.WriteToJson(jsonWriter, null);
+                }
+
+                jsonWriter.WriteEndObject();
+                jsonWriter.Flush();
             }
 
             if (Warnings.Count > 0)
             {
                 using (var file = File.CreateText(Path.Combine(outputPath, CompilationPerfWarningsFileName)))
                 {
-                    var serializer = new JsonSerializer
-                    {
-                        Formatting = Formatting.Indented
-                    };
-
-                    serializer.Serialize(file, Warnings);
+                    JsonSerializer.SerializeAsync(file.BaseStream, Warnings).Wait();
                 }
             }
         }

src/QsCompiler/Compiler/FindNuspecReferences.ps1

@@ -37,7 +37,7 @@ function Add-NuGetDependencyFromCsprojToNuspec($PathToCsproj)
 
         # Check if package already added as dependency, only add if new:
         $added = $dep.dependency | Where { $_.id -eq $id }
-        if (!$added) {
+        if (!$added -and $_.PrivateAssets -ne "All") {
             Write-Host "Adding $id"
             $onedependency = $dep.AppendChild($nuspec.CreateElement('dependency', $nuspec.package.metadata.NamespaceURI))
             $onedependency.SetAttribute('id', $id)
@@ -58,4 +58,3 @@ Add-NuGetDependencyFromCsprojToNuspec "Compiler.csproj" $dep
 # Save into .nuspec file:
 $nuspec.package.metadata.AppendChild($dep)
 $nuspec.Save("$PSScriptRoot\Compiler.nuspec")
-

src/QsCompiler/Core/ConstructorExtensions.fs

@@ -83,7 +83,7 @@ type TypedExpression with
     /// the ResolvedType is set to the type constructed by resolving it using ResolveTypeParameters and the given look-up.
     static member New (expr, typeParamResolutions : ImmutableDictionary<_,_>, exType, exInfo, range) = {
         Expression = expr
-        TypeArguments = typeParamResolutions |> TypedExpression.AsTypeArguments
+        TypeArguments = TypedExpression.AsTypeArguments typeParamResolutions
         ResolvedType = ResolvedType.ResolveTypeParameters typeParamResolutions exType
         InferredInformation = exInfo
         Range = range