This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Add offsets to diagnostic ranges in Core and SyntaxProcessor instead of CompilationManager #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ScottCarda-MS
approved these changes
Aug 10, 2020
Contributor
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
There was a problem hiding this comment.
The changes look good. I just have some questions about the underlying concepts, for my own clarity.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the original problem that drove me to refactor the position and ranges types: I wanted to add the offset to the range directly in SyntaxProcessor, instead of returning a tuple to the CompilationManager. Now it's possible.
This simplifies the return types of several functions from
Position * QsCompilerDiagnostic[]toQsCompilerDiagnostic[], and eliminates the risk that CompilationManager will forget to add the offsets to the range (which happened before: #491).Part of #531.