This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Validate Cycles #561
Merged
Validate Cycles #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarda-MS
requested review from
DmitryVasilevsky,
IrinaYatsenko,
bamarsha,
cesarzc and
swernli
bamarsha
reviewed
Aug 11, 2020
bamarsha
approved these changes
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method in this PR takes a cycle from the call graph, in the form of a sequence of Call Graph Edges, and determines if the cycle is valid or not. Invalid cycles are ones that map type parameters in the cycle to other type parameters of the same cycle (constricting the type parameter), i.e. Foo.A -> Foo.B, or to types that contain the same type parameter, i.e Foo.A -> Foo.A[].
Several unit tests are included.