Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@cesarzc
Copy link
Contributor

@cesarzc cesarzc commented Aug 13, 2020

This change fixes an issue in which building a faulty Q# program succeeds when calling dotnet build twice.

This happens because a bson file is generated when the program is built the first time, even though compilation failed. When dotnet build is invoked for the second time, the bson file already exists and it is newer than the original qs file, so the incremental build skips invoking the compiler command line tool.

The fix is to delete the bson file when Q# compilation fails.

@cesarzc cesarzc linked an issue Aug 13, 2020 that may be closed by this pull request
@cesarzc cesarzc requested a review from bamarsha August 14, 2020 02:51
Copy link
Member

@anpaz anpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cesarzc cesarzc merged commit a571fea into master Aug 17, 2020
@bettinaheim bettinaheim deleted the cesarzc/fix-incremental-build branch August 19, 2020 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build of faulty Q# program succeeds when calling dotnet build twice.

4 participants