This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Address review comments and merge from master for #531 #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/QsCompiler/SyntaxProcessor/StatementVerification.fs
4 tasks
* Split into two project manager queries * Remove Wait() call * Revert "Remove Wait() call" This reverts commit f149e9e. * Add QsCompilerError.Verify call * Apply suggestions from code review Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com> Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com>
* Add ExposeReferencesViaTestNames to assemblyProperties Allows ExposeReferencesViaTestNames to be passed to rewrite steps * Add ExposeReferencesViaTestNames to AssemblyConstants
Contributor
|
@SamarSha Is there a reason this is still a draft PR? |
Contributor
Author
|
I am waiting for your responses in #531 before I know which changes to make here (e.g. the naming of |
Include nested self-resolutions for type parameters as constrictive resolutions.
bettinaheim
approved these changes
Aug 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #531.