This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Enable C# nullable reference types for CommandLineTool project #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamarsha
requested review from
ScottCarda-MS,
bettinaheim,
cesarzc and
swernli
cgranade
approved these changes
Sep 18, 2020
ScottCarda-MS
approved these changes
Sep 19, 2020
Contributor
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
There was a problem hiding this comment.
Very excited to see this change. Is the plan currently to enable the feature, but keep as many things nullable as possible right now by adding the ?, then making things non-nullable as we work with the code?
Contributor
Author
|
My plan is to make as few things nullable as possible (just enough to fix the build errors) without spending too much time refactoring the code to potentially avoid a nullable. |
Contributor
Author
|
I believe a test is failing because CommandLineParser has a bug: commandlineparser/commandline#136. It seems like it was fixed last month in Git, but that version is not available on NuGet yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're planning to gradually enable null checking across the C# projects. This is the first project to get it.