Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Enable C# nullable reference types in Transformations project #644

Merged
bamarsha merged 18 commits into from
Sep 29, 2020
Merged

Enable C# nullable reference types in Transformations project #644

bamarsha merged 18 commits into from
Sep 29, 2020

Conversation

@bamarsha
Copy link
Contributor

@bamarsha bamarsha commented Sep 23, 2020 •
edited
Loading

Closes #634.

Sarah Marshall added 15 commits September 23, 2020 11:42
ScottCarda-MS
ScottCarda-MS approved these changes Sep 24, 2020
View reviewed changes
bamarsha
bamarsha commented Sep 24, 2020
View reviewed changes
@bamarsha bamarsha mentioned this pull request Sep 24, 2020
Merged
@ScottCarda-MS ScottCarda-MS mentioned this pull request Sep 24, 2020
Merged
@bamarsha
Copy link
Contributor Author

bamarsha commented Sep 29, 2020

While we're still discussing if using InternalsVisibleTo is a good idea, I'm merging this and the other nullable PRs in the meantime. We can change the visibility of the utility functions later if needed.

@bamarsha bamarsha merged commit 6602eed into main Sep 29, 2020
@bamarsha bamarsha deleted the samarsha/transformations-nullable branch September 29, 2020 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

@swernli swernli Awaiting requested review from swernli

@cesarzc cesarzc Awaiting requested review from cesarzc cesarzc is a code owner

@cgranade cgranade Awaiting requested review from cgranade

1 more reviewer

@ScottCarda-MS ScottCarda-MS ScottCarda-MS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AccumulateIdentifiers transformation throws NullReferenceException if AST is missing locations

3 participants

@bamarsha @ScottCarda-MS