This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Compilation error for naming conflicts with namespace names #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swernli I believe it should be sufficient to check that a declaration doesn't conflict with the full namespace name. Checking that it doesn't conflict with a (C#) partial namespace name should not be needed for the autogenerated code to work fine - correct me if you see an issue with that. |
swernli
approved these changes
Sep 25, 2020
Contributor
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
Yes, this change looks good! Thanks for fixing this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #575.