This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Call Graph to Main #654
Merged
Call Graph to Main #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T classes so they don't use positional information. This lets us safely hash these values at the transformation level.
…conventions. Fixed missing reference to namespace sub-transformation. Added DependencyType to CallGraph.
…for ToDo's. Used StripPositionInfo instead of RemovePositionInfo.
bamarsha
reviewed
Sep 29, 2020
bamarsha
reviewed
Oct 1, 2020
bettinaheim
reviewed
Oct 9, 2020
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
All in all this has come together really nicely!
src/QsCompiler/Transformations/CallGraph/CallGraphWalkerBase.cs
Outdated
Show resolved
Hide resolved
src/QsCompiler/Transformations/CallGraph/CallGraphWalkerBase.cs
Outdated
Show resolved
Hide resolved
bamarsha
reviewed
Oct 13, 2020
bettinaheim
suggested changes
Oct 14, 2020
bettinaheim
reviewed
Oct 14, 2020
bettinaheim
reviewed
Oct 14, 2020
bettinaheim
reviewed
Oct 14, 2020
bettinaheim
approved these changes
Oct 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Call Graph data structures and several use cases for them, such as invalid cycle diagnostics, and cleaner monomorphization code.
New to this PR: