This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Enable C# nullable reference types in test projects #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamarsha
requested review from
ScottCarda-MS,
bettinaheim,
cesarzc,
cgranade and
swernli
cesarzc
reviewed
Sep 30, 2020
cesarzc
reviewed
Sep 30, 2020
cesarzc
reviewed
Sep 30, 2020
cesarzc
approved these changes
Sep 30, 2020
Contributor
cesarzc
left a comment
cesarzc
left a comment
There was a problem hiding this comment.
Looks good! Thanks again for making all these changes.
ScottCarda-MS
approved these changes
Sep 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up using the null-forgiving operator
!in a few places - mainly afterAssert.IsNotNull, because the compiler doesn't realize the variable isn't nullable after this statement, and in one place where a non-nullable field in a test class is initialized after the class is created. Normally I would try to avoid!, but for a test project it seems OK.