Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Add vsce to devDependencies #664

Merged
bamarsha merged 2 commits into from
Oct 6, 2020
Merged

Add vsce to devDependencies #664

bamarsha merged 2 commits into from
Oct 6, 2020

Conversation

@bamarsha
Copy link
Contributor

@bamarsha bamarsha commented Oct 5, 2020

This pins vsce to version 1.81.1 and installs it locally to node_modules, instead of using npm install -g to install it as a global tool. This prevents vsce updates from affecting builds of the QDK extension for VS Code without being tested first.

rmshaffer
rmshaffer approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@rmshaffer rmshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@bamarsha bamarsha merged commit 0e6a240 into main Oct 6, 2020
@bamarsha bamarsha deleted the samarsha/vsce branch October 6, 2020 01:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cgranade cgranade Awaiting requested review from cgranade

@efratshabtai efratshabtai Awaiting requested review from efratshabtai

2 more reviewers

@rmshaffer rmshaffer rmshaffer approved these changes

@ricardo-espinoza ricardo-espinoza ricardo-espinoza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bamarsha @rmshaffer @ricardo-espinoza