This repository was archived by the owner on Jan 12, 2024. It is now read-only.
adding support for binary and octal BigInt #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
Thanks for the PR! I'll make sure it's reviewed soon. |
bamarsha
reviewed
Oct 15, 2020
Contributor
bamarsha
left a comment
bamarsha
left a comment
There was a problem hiding this comment.
I think this looks like the right approach! Just added some comments for simplifying parts of the code.
bamarsha
changed the title
bamarsha
reviewed
Oct 19, 2020
bamarsha
approved these changes
Oct 20, 2020
Contributor
bamarsha
left a comment
bamarsha
left a comment
There was a problem hiding this comment.
It looks good, thanks for your contribution!
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #610
But note this currently only adds binary BigInt, not yet octal. I was thinking if this looks alright then I will first rewrite octal into binary string and then parse binary string to hex, which is less efficient than writing octal directly to hex - but that requires enumerating too many cases...