This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Monomorphization Access Modifiers #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
reviewed
Oct 21, 2020
src/QsCompiler/Tests.Compiler/TestCases/LinkingTests/Monomorphization.qs
Show resolved
Hide resolved
bettinaheim
approved these changes
Oct 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where access modifiers for concretizations generated during monomorphization were simply assigned the access of their generic parent. This causes an issue if any of the concretizing types are more restrictive than the original generic callable. This PR fixes this by taking the most restrictive of all the access modifiers between the original callable and all of the concretizing types.
This also adds a unit test to make sure type arguments are handled correctly by monomorphization.