Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Minor fixes to new documentation generation tool #678

Merged
cgranade merged 3 commits into from
Oct 15, 2020
Merged

Minor fixes to new documentation generation tool #678

cgranade merged 3 commits into from
Oct 15, 2020

Conversation

@cgranade
Copy link
Contributor

@cgranade cgranade commented Oct 15, 2020

This PR makes a couple fixes to the new documentation generation tool that were discovered using beta packages from the previous PR (#594):

  • Default package ID not being set correctly.
  • Output path not being passed through to assembly constants due to issue with MSBuild conditional attributes.
  • ToMarkdownLink falling through to "__invalid__" for type parameters as well as for invalid types.

swernli
swernli approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cgranade cgranade merged commit a243954 into feature/docgen Oct 15, 2020
@cgranade cgranade deleted the cgranade/docgen-fixes branch January 25, 2021 23:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

1 more reviewer

@swernli swernli swernli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cgranade @swernli