This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix reversal of nested adjoint expressions #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
requested review from
IrinaYatsenko,
ScottCarda-MS,
bamarsha and
bettinaheim
swernli
commented
Oct 17, 2020
Contributor
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
There was a problem hiding this comment.
Looks good! I've added some suggestions for reducing the additions to the public API.
ScottCarda-MS
approved these changes
Oct 19, 2020
bettinaheim
reviewed
Oct 20, 2020
Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating an adjoint operation, first lift any nested expressions that are operation calls into their own lines, replacing the inline call with Unit, ie:
( ), since all adjointable operations must return Unit anyway. Doing this lifting before the statements in the scope get reversed ensures that they will be properly reversed instead of left in-order in the in-line expression.Fixes #615