This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Concrete Call Graph Support Self-Adjoint Generator Directives #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarda-MS
requested review from
bamarsha,
bettinaheim,
cesarzc and
swernli
bettinaheim
reviewed
Oct 21, 2020
bettinaheim
approved these changes
Oct 21, 2020
…com/microsoft/qsharp-compiler into sccarda/CallGraphSupportSelfAdjoint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concrete call graph assumes that the functor generation has been applied to the given compilation and that all generator directives have been processed and removed. However the functor generation does not remove the self-inverse generator directives and leaves them in the compilation. The concrete call graph is updated in the PR to accommodate the self-inverse generator directives by adding dependencies from adjoint and controlled adjoint specializations marked as 'self' to the body and controlled specializations, respectively, of the same callable.