This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Create a new DotnetCoreDll property for the current syntax tree resource name #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the resource currently used by the compiler to attach the syntax tree to a DLL.
rmshaffer
approved these changes
Nov 18, 2020
vxfield
added a commit
that referenced
this pull request
Nov 23, 2020
* Setting KV task to v1 (#743) * Create a new DotnetCoreDll property for the current syntax tree resource name (#741) * Create a new DotnetCoreDll property that always provides the name of the resource currently used by the compiler to attach the syntax tree to a DLL. * Fix typo. * Explicitly build language server during pack-extension.ps1 Co-authored-by: Andres Paz <anpaz@microsoft.com> Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com>
vxfield
added a commit
that referenced
this pull request
Nov 23, 2020
* Setting KV task to v1 (#743) * Create a new DotnetCoreDll property for the current syntax tree resource name (#741) * Create a new DotnetCoreDll property that always provides the name of the resource currently used by the compiler to attach the syntax tree to a DLL. * Fix typo. * Explicitly build language server during pack-extension.ps1 * Missing ASSEMBLY_CONSTANTS Co-authored-by: Andres Paz <anpaz@microsoft.com> Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com>
vxfield
added a commit
that referenced
this pull request
Nov 23, 2020
* Setting KV task to v1 (#743) * Create a new DotnetCoreDll property for the current syntax tree resource name (#741) * Create a new DotnetCoreDll property that always provides the name of the resource currently used by the compiler to attach the syntax tree to a DLL. * Fix typo. * Explicitly build language server during pack-extension.ps1 * Missing ASSEMBLY_CONSTANTS Co-authored-by: Andres Paz <anpaz@microsoft.com> Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com>
vxfield
added a commit
that referenced
this pull request
Nov 23, 2020
* Setting KV task to v1 (#743) * Create a new DotnetCoreDll property for the current syntax tree resource name (#741) * Create a new DotnetCoreDll property that always provides the name of the resource currently used by the compiler to attach the syntax tree to a DLL. * Fix typo. * Explicitly build language server during pack-extension.ps1 * Missing ASSEMBLY_CONSTANTS * Add args back * remove file Co-authored-by: Andres Paz <anpaz@microsoft.com> Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com>
vxfield
added a commit
that referenced
this pull request
Nov 23, 2020
* Setting KV task to v1 (#743) * Create a new DotnetCoreDll property for the current syntax tree resource name (#741) * Create a new DotnetCoreDll property that always provides the name of the resource currently used by the compiler to attach the syntax tree to a DLL. * Fix typo. * Explicitly build language server during pack-extension.ps1 * Missing ASSEMBLY_CONSTANTS * Add args back * remove file Co-authored-by: Andres Paz <anpaz@microsoft.com> Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com>
cesarzc
deleted the
cesarzc/current-syntax-tree-serialization-resource-name
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a new DotnetCoreDll property that always provides the name of the resource currently used by the compiler to attach the syntax tree to a DLL.
This property can be leveraged by consumers of the compiler API (e.g. IQ#) which also use the
CompilationLoader.Write()method and attach the serialized syntax tree to a DLL.