This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Detect absence of .NET SDK 3.1 and display error message #755
+108
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound (cherry picked from commit 59681e9)
(cherry picked from commit b538b3d)
(cherry picked from commit 28e79dd)
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> (cherry picked from commit f2cd93b)
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> (cherry picked from commit de463e0)
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> (cherry picked from commit 7911bd5)
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> (cherry picked from commit c19177d)
(cherry picked from commit 283cecd)
(cherry picked from commit 833af12)
…ldLocator (cherry picked from commit 64d7d11)
(cherry picked from commit dc99a4b)
Member
Author
|
@SamarSha, @bettinaheim: this is exactly the same approved PR #753 but now targeting the main branch. |
bamarsha
suggested changes
Nov 25, 2020
| "version": "3.1.100", | ||
| "rollForward": "latestFeature" | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
We should have only one global.json that applies to the compiler repository. Currently, the global.json at the root of the repository also sets the SDK version to 3.1, but it may be updated to support 5 soon. In that case, running dotnet from the LanguageServer folder will require 3.1, but may use 5 when run from any other folder.
Since this global.json is intended to only be used by the language server after it's built and running, is it possible for it to have a different name in the source folder that dotnet won't recognize, but have it be renamed to global.json in the output directory?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mitigates issue #737 by: