Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@bettinaheim
Copy link
Contributor

@bettinaheim bettinaheim commented Dec 4, 2020

This PR

  • splits out the QIR data structures that are not specific to Q#,
  • cleans up the API of the QIR Generator
  • properly integrates the QIR generation pass into the compiler
  • adds an additional pass to arrange the target intrinsics in the format that the QIR generator expects them (one specialization per intrinsic callable, tagged with the appropriate attributes)
  • enables QIR emission as part of the Sdk (i.e. via project property)
  • contains some minor clean-up to the docs generator extension
  • ensures that the concrete call graph always contains all specializations for a used callable

@bettinaheim bettinaheim changed the title API pass and clean-up for QIR Generator Compiler integration and clean up for QIR generation Dec 7, 2020
Copy link
Contributor

@ScottCarda-MS ScottCarda-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to split this PR into several different PRs into a feature branch so that the content can be more easily reviewed? It seems like some of these changes could be reviewed independently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants