This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix ClassicallyControlled Rewrite bugs #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change includes 3 fixes/updates to the ClassicallyControlled rewrite step: 1. It adds handling for ExpressionKind.NOT so that those conditions get properly restructured and processed for lifting (fixes #763) 2. If a conditional statement has an empty scope, it gets replaced with a call to `NoOp` instead of being lifted into an empty callable. 3. Updates the propagation of `IsValidScope` through the recursive calls to avoid lifting outer conditional scopes when inner scopes are not valid for lifting.
swernli
requested review from
DmitryVasilevsky,
ScottCarda-MS,
bamarsha and
bettinaheim
ScottCarda-MS
approved these changes
Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes 3 fixes/updates to the ClassicallyControlled rewrite step:
NoOpinstead of being lifted into an empty callable.Updates the propagation ofThe fix here was incorrect, so it was removed and a separate issue Nested Conditional blocks may be incorrectly lifted #768 was filed.IsValidScopethrough the recursive calls to avoid lifting outer conditional scopes when inner scopes are not valid for lifting.Things left to do before check-in:
NoOp)Add test case for nested conditionals that cannot be lifted