This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Adds ConcreteIntrinsicGen Property #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
reviewed
Dec 14, 2020
swernli
approved these changes
Dec 15, 2020
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ConcreteIntrinsicGen Property as an assembly constant and Q# project property. This property will be used by the C# generation rewrite step to determine if an intrinsic operation is generated in C# as an abstract class (original and default behavior) or a concrete class (new behavior from using property). The logic that will utilize this property is found in the runtime repo under the branch 'swernli/decomp-interfaces', specifically here: https://github.com/microsoft/qsharp-runtime/blob/swernli/decomp-interfaces/src/Simulation/CsharpGeneration/SimulationCode.fs