This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Improve deserializer initialization time #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamarsha
approved these changes
Jan 11, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the deserializer initialization time by setting the
inlineNestedconstructor argument tofalse.This change is an application of a suggestion described in an issue in the Bond repository.
The documentation comment of the
inlineNestedargument of the constructor mentions that when this argument is set to true it inline nested types if possible (optimizes for reduction of execution time at the expense of initialization time and memory). This means that setting this tofalsemight reduce initialization time.After doing some experiments with a quantum teleportation Q# project, setting this argument to false greatly reduces the deserializer initialization time significantly (from ~2500 ms to ~1000 ms) while not having a measurable degradation on the deserialization time itself.
Here's the experiments' data:
inlineNested = true
inlineNested = false