Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@jviszlai
Copy link

Adds support for parsing the syntax of attributes. Includes some specific error handling for if the ending tag is missing on an attribute or the arguments are missing for an attribute, as well as context verification so that the attribute is only above an operation, function, or type definition.

Making this a draft pull request until a feature branch exists for attributes.

Targets #81

@bettinaheim
Copy link
Contributor

@jviszlai Thanks again for the contribution, and sorry for the delay in processing!
I don't know what the best way is to contact you, but if you reach out and contact me on my Microsoft address we've got a surprise for you. :) Purely optional of course.

@jviszlai
Copy link
Author

jviszlai commented Aug 23, 2019

@jviszlai Thanks again for the contribution, and sorry for the delay in processing!
I don't know what the best way is to contact you, but if you reach out and contact me on my Microsoft address we've got a surprise for you. :) Purely optional of course.

@bettinaheim No worries! I don't have access to anything in Microsoft since my internship ended so I couldn't find your email. Thanks again for the opportunity to learn about this!

@bettinaheim bettinaheim changed the base branch from master to hackathon August 27, 2019 01:23
@bettinaheim
Copy link
Contributor

@jviszlai
Thank for this awesome PR! I suggest to merge this into a separate branch so I can update it with the changes from master, and can add the necessary support to actually do something cool with the attributes. :) Sounds good?

Let me know if you would like to pick up some work, and whether you would like to continue on this, or maybe you would also like to look at something else. Cheers!

@jviszlai
Copy link
Author

jviszlai commented Aug 28, 2019

@bettinaheim Sounds good! I'll mark it as ready to be merged into the hackathon branch if that works?

@jviszlai jviszlai marked this pull request as ready for review August 28, 2019 17:13
@bettinaheim
Copy link
Contributor

@jviszlai Perfect, thanks!

Copy link
Contributor

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this awesome contribution!

@bettinaheim bettinaheim merged commit 1128456 into microsoft:hackathon Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants