This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Treat C# and F# warnings as errors #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2021 17:10
Contributor
|
How will this affect things like classes being marked as deprecated? I know we generally try to not to use deprecated structures, but sometimes during multi-part work it's convenient to add the new infrastructure, mark the old one as deprecated, and then go around update all the consumers. EDIT: never mind, I realize now that we can just put specific suppressions in if there needs to be that kind of delay between deprecation and update :) |
Contributor
Author
|
Yeah, you can use |
cesarzc
reviewed
Jan 22, 2021
cesarzc
approved these changes
Jan 23, 2021
Contributor
cesarzc
left a comment
cesarzc
left a comment
There was a problem hiding this comment.
Thanks for doing this Sarah!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the CI to build with
/property:TreatWarningsAsErrors=true. This means that warnings are allowed when developing locally, but all warnings must be fixed or suppressed before a PR can be merged.This applies to C# and F# warnings, but not MSBuild and Q# warnings.