This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Separate entry point that prints the results #914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
changed the title
kuzminrobin
reviewed
Mar 23, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Show resolved
Hide resolved
kuzminrobin
reviewed
Mar 23, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Show resolved
Hide resolved
kuzminrobin
reviewed
Mar 23, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Show resolved
Hide resolved
kuzminrobin
reviewed
Mar 23, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Show resolved
Hide resolved
kuzminrobin
reviewed
Mar 23, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Show resolved
Hide resolved
kuzminrobin
reviewed
Mar 23, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Outdated
Show resolved
Hide resolved
kuzminrobin
reviewed
Mar 23, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Show resolved
Hide resolved
kuzminrobin
reviewed
Mar 23, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Outdated
Show resolved
Hide resolved
kuzminrobin
reviewed
Mar 23, 2021
src/QsCompiler/QirGeneration/Subtransformations/ExpressionKindTransformation.cs
Show resolved
Hide resolved
kuzminrobin
approved these changes
Mar 23, 2021
Contributor
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
C# is like Chinese for me. I don't understand most of it.
I looked at ExpressionKindTransformation.cs mostly (it contained a continuous block of code that seemed similar to C/C++).
All my notes can be false alarms. Feel free to ignore.
Approving.
added 4 commits
March 23, 2021 19:43
…rp-compiler into beheim/entryPoint
Contributor
Author
Thanks for the review; it was very useful and very much needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the interop wrapper that is created for entry points, this PR also adds another IrFunction that has the same argument list as the interop wrapper, calls into the entry point, but instead of returning the result, uses message to print it instead, and returns void.
This PR adds the missing support to process tuples, udts, and arrays in interpolated strings.
It also fixes an issue with diagnostics from rewrite steps that seems to be a result of a recent package update of the language server package (and some inconsistent nullable information in that package).
The build on this PR is currently failing due to a missing API function in the runtime.