This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Separate packaging of QIR emission as a compiler extension #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…qsharp-compiler into beheim/commandLineArg
…on the Q# compiler, all tests pass
…apability is full computation
swernli
reviewed
Mar 25, 2021
Contributor
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
I see a few places that I'm worried may cause some headache for us. It's possible these can be addressed in a later PR, but I'd like to see what you think first before signing off.
bettinaheim
force-pushed
the
beheim/packaging
branch
from
c99c1f8 to
aac9333
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…p-compiler into beheim/packaging
…p-compiler into beheim/packaging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the QIR emission pass into a separate compiler extension package. The change is mainly pursued due to the size of LlvmLib.