This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Monomorphize intrinsics when keepAllIntrinsics is false #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzminrobin
approved these changes
Apr 1, 2021
Contributor
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
(I hardly understand the code ;-)
Contributor
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
There was a problem hiding this comment.
Unfortunately these changes conflict greatly with the changes for the Trim Rewrite Step, as the Monomorphization will no longer have the keepAllIntrinsic behavior. Because of that, I would prefer to add the fix to the issue to that PR instead so that it is well integrated. @bettinaheim could we chat offline about what is best to do here?
added 2 commits
April 2, 2021 10:47
ScottCarda-MS
approved these changes
Apr 2, 2021
Contributor
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
There was a problem hiding this comment.
This looks good. Thanks for making the changes to retarget this to my branch!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is required to support DumpMachine and DumpRegister.