This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Unit tests in Executables #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzminrobin
reviewed
Apr 9, 2021
kuzminrobin
reviewed
Apr 9, 2021
kuzminrobin
reviewed
Apr 9, 2021
kuzminrobin
approved these changes
Apr 9, 2021
Contributor
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
Approving with some questions to your discretion.
I only understand .qs. I recommend at least one more review/approval for .fs, .cs.
ScottCarda-MS
force-pushed
the
sccarda/MonomorphizationMultiEntryPoints
branch
from
816f5df to
3e7e988
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates call graph classes to process unit types as starting points to the call graph, similar to how entry points are used. This allows unit tests to be used in executables ensuring they will not be trimmed and their dependencies will be properly monomorphized.