This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix #949. #953
Merged
Fix #949. #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamarsha
reviewed
Apr 8, 2021
bamarsha
approved these changes
Apr 8, 2021
Contributor
bamarsha
left a comment
bamarsha
left a comment
There was a problem hiding this comment.
If only C# had switch exhaustiveness checking...
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Contributor
Author
Weirdly, it does, but that feature is undermined by the fact that, in order to support bitflag-style enums, C# Anyway, thanks for reviewing and for catching the bad link! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in the documentation generation pipeline that causes some inputs of type
Resultto be formatted asinvalidinstead (#949).