This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Don't reference the llvmlibs in the command line compiler #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
commented
Apr 23, 2021
swernli
reviewed
Apr 23, 2021
swernli
approved these changes
Apr 23, 2021
Contributor
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
I think this approach will get us the behavior that we need! Signing off assuming we'll also test an alpha QDK package from the e2e build to confirm QIR generation still works as expected.
added 4 commits
April 23, 2021 15:04
ricardo-espinoza
pushed a commit
that referenced
this pull request
Apr 24, 2021
ricardo-espinoza
added a commit
that referenced
this pull request
Apr 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of referencing the llvmlibs that are needed for QIR generation in the command line compiler, which has the consequence that they are packaged with the sdk, we make them a private asset in the Q# project for which to generate QIR, and use GeneratePathProperty to pass the path where to look for them to the command line compiler. This has the advantage that now the llvmlibs only need to be downloaded when either the nuget cache has been cleared, or we update the used llvm version.
This PR fixes #937.