Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@ziqi-ma
Copy link
Contributor

@ziqi-ma ziqi-ma commented Oct 23, 2020

addressing #42

Copy link
Contributor

@bamarsha bamarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Since the sections on Int literals and BigInt literals are very similar, I think it would be good to make the BigInt section more consistent with the Int section regarding wording and formatting.

Copy link
Contributor

@bamarsha bamarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@bamarsha bamarsha merged commit e948edb into microsoft:main Oct 28, 2020
@bamarsha bamarsha linked an issue Oct 28, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigInt literals now accept binary and octal formats

2 participants