This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Separate stack trace handling into new OnException event. #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpaz
approved these changes
Mar 10, 2020
| /// Adds an event to the OnStackTrace event that logs stack traces | ||
| /// as plain text via the OnLog event (e.g.: for console output). | ||
| /// </summary> | ||
| public void EnableDefaultStackTraceHandling() |
Member
There was a problem hiding this comment.
Maybe name this EnablePrintException is not handling StackTrace but how exceptions are handled...
Co-Authored-By: Andres Paz <anpaz@microsoft.com>
…qsharp-runtime into cgranade/on-exception
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates stack trace handling into a new event, paralleling the design of
OnLog. This PR also separates our source file identification logic into a method that can be called separately in anticipation of picking that feature up from IQ# and providing rich stack traces there.(NB: as I've been making PRs, I try to add
#nullable enable. In this case, that has identified some potential issues with qubit managers being null that might be worth addressing in future PRs.)