This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Add Honeywell to QuantumMachineFactory #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmshaffer
approved these changes
May 19, 2020
Contributor
|
Looks good! No worries about the merge conflict with #205, we need to first decide what the right approach is there anyway. |
Member
|
This is going to conflict with #205 , you might want to pick that up? |
Member
|
doh. sorry, i looked at the comment afterwards. |
anpaz
approved these changes
May 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping
Type.GetTypesince that works for the standalone executable, but this will have a merge conflict with #205.