This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix C# Generation for UDT Tuple Field #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds of the UDT where not being correctly parsed.
bettinaheim
previously requested changes
Jun 19, 2020
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
Could you please add tests for this?
ScottCarda-MS
commented
Jun 19, 2020
bettinaheim
reviewed
Jun 23, 2020
bettinaheim
approved these changes
Jun 23, 2020
…soft/qsharp-runtime into sccarda/UDTTupleTypeBugFix
AniketDalvi
pushed a commit
that referenced
this pull request
Jul 1, 2020
Fixed an issue with the C# generation for UDT classes where tuple fields of the UDT where not being correctly parsed. Added some tests for this situation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #40.
Fixed an issue with the C# generation for UDT classes where tuple fields of the UDT where not being correctly parsed.