This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Cgranade/qproc type #304
Closed
Cgranade/qproc type #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #298 by adding a new
QuantumProcessorDispatcher<TProcessor>type whose type parameter represents the implementation ofIQuantumProcessorused by a particular dispatcher. This in turn allows for projects such as microsoft/Quantum#379 to make use of additional methods and properties on processors in subclasses of dispatchers without requiring reflection or runtime casts.This PR also adds support for generating diagnostic data (see #283) from processor implementations, makes
#nullable enableimprovements and adds missing API documentation.